Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): detect stream reset signal #4144

Merged
merged 4 commits into from May 26, 2021
Merged

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented May 21, 2021

Preparation for admin seek.

Modifies retryableStream to detect the Pub/Sub Lite RESET signal and forward the notification to the streamHandler implementation. The RESET signal is just a Status that contains particular error details. Upon receipt, the Subscribe stream will reset its state and handle an out-of-band seek operation.

@tmdiep tmdiep requested review from as code owners May 21, 2021
@google-cla google-cla bot added the cla: yes label May 21, 2021
@tmdiep tmdiep requested a review from hongalex May 21, 2021
@tmdiep tmdiep changed the title feat(pubsublite): detect reset signal feat(pubsublite): detect stream reset signal May 21, 2021
pubsublite/internal/wire/rpc.go Outdated Show resolved Hide resolved
pubsublite/internal/wire/streams.go Outdated Show resolved Hide resolved
@tmdiep tmdiep merged commit ff5f8c9 into googleapis:master May 26, 2021
3 checks passed
@tmdiep tmdiep deleted the seek_streams branch May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants