Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): support out of band seeks #4208

Merged
merged 4 commits into from Jun 15, 2021
Merged

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jun 3, 2021

Supports admin/out of band seeks pushed from the server.

  • Handles the RESET signal (i.e. out of band seek notification) from the server. Discards outstanding acks from delivered messages, waits for the committer to flush commits and then resets all committer and subscriber state. The next subscriber reconnect will read from the COMMITTED_CURSOR.
  • Instead of issuing an internal seek request after the initial subscribe request, sets the new InitialSubscribeRequest.initial_location field. Explicitly setting COMMITTED_CURSOR for the initial_location is required for the subscriber to acknowledge the seek notification.
@tmdiep tmdiep merged commit 1432e67 into googleapis:master Jun 15, 2021
4 checks passed
@tmdiep tmdiep deleted the admin_seek branch Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants