Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite): ack assignment after removed subscribers have terminated #4217

Merged
merged 3 commits into from Jun 15, 2021

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jun 4, 2021

  • assigningSubscriber - Return from handleAssignment() after partition subscribers have fully terminated. This waits for pending commits to be acknowledged by the server. This avoids commits races with the next assigned client.
  • assigner - Just a no-op refactor to wait for receiveAssignment() to finish without holding the mutex, since it's now blocking on IO.
@tmdiep tmdiep merged commit 0ad3f16 into googleapis:master Jun 15, 2021
4 checks passed
@tmdiep tmdiep deleted the assigner_wait_committed branch Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants