Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gkeconnect/gateway): start generating apiv1beta1 #4235

Merged
merged 4 commits into from Jun 9, 2021
Merged

feat(gkeconnect/gateway): start generating apiv1beta1 #4235

merged 4 commits into from Jun 9, 2021

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Jun 8, 2021

No description provided.

@codyoss codyoss requested a review from as a code owner Jun 8, 2021
@google-cla google-cla bot added the cla: yes label Jun 8, 2021
@codyoss codyoss requested a review from noahdietz Jun 8, 2021
@codyoss
Copy link
Member Author

@codyoss codyoss commented Jun 8, 2021

@noahdietz For some reason the import for gatewaypb is not being generated into the imports. Any ideas why? Looks like the RPC don't deal with types from that package but just httpbody. Maybe that is why?

Loading

@noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Jun 8, 2021

Oop yes this was fixed in v0.20.2 of the generator. Turns out the proto has no request/response messages of its own (they are are google.api.HttpBody) and the generator apparently was only adding the API's pb import when it resolved request/response messages. Updating the generator in the pipeline should fix it. Sorry about that.

Loading

@codyoss
Copy link
Member Author

@codyoss codyoss commented Jun 8, 2021

No worries, thanks for the info!

Loading

@codyoss codyoss merged commit 1c3e968 into googleapis:master Jun 9, 2021
4 checks passed
Loading
@codyoss codyoss deleted the gen-gat-v1b1 branch Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants