Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite): ensure api clients are closed when startup fails #4239

Merged
merged 2 commits into from Jun 10, 2021

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jun 9, 2021

  • Ensure that NewSubscriber and NewPublisher constructors close all created API clients if they partially fail.
  • Added an apiClientService base class to handle closing clients when startup fails, as well as after shutdown.
@tmdiep tmdiep merged commit 55025a1 into googleapis:master Jun 10, 2021
3 checks passed
@tmdiep tmdiep deleted the clients_close branch Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants