Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): add autogenerated header to snippets #4261

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

noahdietz
Copy link
Contributor

Fixes #4260

@noahdietz noahdietz requested a review from a team as a code owner June 14, 2021 18:31
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2021
@@ -268,4 +268,6 @@ const licenseHeader string = `// Copyright %v Google LLC
// See the License for the specific language governing permissions and
// limitations under the License.

// Code generated by cloud.google.com/go/internal/gapicgen/gensnippets. DO NOT EDIT.
Copy link
Contributor Author

@noahdietz noahdietz Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could exclude the by cloud.google.com/go/internal/gapicgen/gensnippets altogether per the documented rule. https://golang.org/cmd/go/#hdr-Generate_Go_files_by_processing_source

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2220787 into googleapis:master Jun 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
@tbpg
Copy link
Contributor

tbpg commented Jun 17, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal/gensnippets: include comment indicating code is autogenerated
3 participants