Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite): make SubscriberClient.Receive identical to pubsub #4281

Merged
merged 4 commits into from Jun 22, 2021

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jun 17, 2021

  • Ensures that pscompat.SubscriberClient.Receive and pubsub.Subscription.Receive have identical interfaces.
  • Adds examples for how to declare common interfaces for pubsublite and pubsub.
  • Amended docs to point to these examples.
  • Other misc doc cleanups.
Copy link
Member

@codyoss codyoss left a comment

LGTM, thanks!

@tmdiep
Copy link
Contributor Author

@tmdiep tmdiep commented Jun 22, 2021

Thanks for reviewing!

@tmdiep tmdiep merged commit 5b5d0f7 into googleapis:master Jun 22, 2021
4 checks passed
@tmdiep tmdiep deleted the pubsub_interfaces branch Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants