Skip to content

feat(internal/godocfx): different metadata for different modules#4297

Merged
tbpg merged 4 commits intomasterfrom
metadata
Jun 22, 2021
Merged

feat(internal/godocfx): different metadata for different modules#4297
tbpg merged 4 commits intomasterfrom
metadata

Conversation

@tbpg
Copy link
Copy Markdown
Contributor

@tbpg tbpg commented Jun 22, 2021

I refactored the writing of the metadata into a separate function so it can be tested directly.

@tbpg tbpg requested review from a team and codyoss June 22, 2021 15:44
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2021
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbpg tbpg added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jun 22, 2021
@tbpg tbpg merged commit 598f5b9 into master Jun 22, 2021
@tbpg tbpg deleted the metadata branch June 22, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants