Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): retry all goaway errors #4384

Merged
merged 3 commits into from Jul 7, 2021

Conversation

@hongalex
Copy link
Member

@hongalex hongalex commented Jul 7, 2021

The previous iteration of this PR, #4313, only retried GOAWAY in conjunction with an EOF string, which doesn't capture all GOAWAY errors. Now, all error messages with GOAWAY and error code UNKNOWN are retried.

Fixes #4257

codyoss
codyoss approved these changes Jul 7, 2021
Copy link
Member

@codyoss codyoss left a comment

LGTM

Loading

@gcf-merge-on-green gcf-merge-on-green bot merged commit 1eae86f into googleapis:master Jul 7, 2021
4 checks passed
Loading
@hongalex hongalex deleted the pubsub-goaway branch Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants