Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spansql): support ALTER DATABASE #4403

Merged
merged 6 commits into from Jul 12, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Jul 9, 2021

Adds support for ALTER DATABASE dbname SET OPTIONS (..) statements.

Resolves #4390

olavloite added 2 commits Jul 9, 2021
Adds support for ALTER DATABASE dbname SET OPTIONS (..) statements.

Resolves #4390
@olavloite olavloite requested a review from hengfengli Jul 9, 2021
@olavloite olavloite requested review from skuruppu and a team as code owners Jul 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Jul 9, 2021
spanner/spansql/parser.go Outdated Show resolved Hide resolved
spanner/spansql/parser.go Outdated Show resolved Hide resolved
spanner/spansql/parser.go Outdated Show resolved Hide resolved
spanner/spansql/parser.go Outdated Show resolved Hide resolved
spanner/spansql/types.go Outdated Show resolved Hide resolved
spanner/spansql/sql_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hengfengli hengfengli left a comment

LGTM. Thanks for making this change. Just left a few comments.

@olavloite
Copy link
Contributor Author

olavloite commented Jul 12, 2021

LGTM. Thanks for making this change. Just left a few comments.

Thanks for the review. I've addressed / answered your comments. PTAL.

@hengfengli hengfengli changed the title feat(spansql): support ALTER DATABASE feat(spanner/spansql): support ALTER DATABASE Jul 12, 2021
@hengfengli hengfengli merged commit 1458dc9 into master Jul 12, 2021
5 checks passed
@hengfengli hengfengli deleted the spansql-alter-database branch Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner/spansql: Support ALTER DATABASE (SET OPTIONS) statements
2 participants