feat(bigquery/storage/managedwriter): add base client #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a base client and implements some of the surface. All the streaming client abstractions are elided and will be introduced in subsequent PRs, but this PR does include non-streaming RPC methods Alongside the client, we introduce an option type (WriterOption) for constructing a client in a variadic fashion. The client contains an internal settings type, streamSettings, which contains fields of note for both the streaming client abstraction and its flow controller. Testing: This PR contains unit tests, but doesn't include integration tests. I'll start hoisting that in soon.
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
codyoss
reviewed
Jul 13, 2021
codyoss
reviewed
Jul 14, 2021
| } | ||
|
|
||
| // NewManagedStream establishes a new stream for writing. | ||
| func (c *Client) NewManagedStream(ctx context.Context, table *bigquery.Table, opts ...WriterOption) (*ManagedStream, error) { |
There was a problem hiding this comment.
I think table could just be datasetID and tableID. I worry about this client reaching for code in both directions up and down the file structure. This means the core bigquery package could never rely on this package due to cycles.
There was a problem hiding this comment.
Fine switching it to string, now I'm wondering if it should be a variadic argument. We don't do anything with the reference other than for the construct a stream case, but if we allow users to pass in an optional stream ID perhaps we let them treat table as optional as well? Will switch it and augment the validation (your other comment) and see how it plays.
codyoss
reviewed
Jul 14, 2021
codyoss
approved these changes
Jul 14, 2021
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a base client and managed stream abstraction, and
implements some of the associated surfaces. All the
streaming client abstractions are elided and will be introduced in
subsequent PRs, but this PR does include non-streaming RPC methods
Alongside the client, we introduce an option type (WriterOption) for
constructing a client in a variadic fashion.
The client contains an internal settings type, streamSettings, which
contains fields of note for both the streaming client abstraction and
its flow controller.
Testing: This PR contains unit tests, but doesn't include integration
tests. I'll start hoisting that in soon.
Towards: #4366