Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add row.String() and refine error message for decoding a struct array #4431

Merged
merged 4 commits into from Jul 15, 2021

Conversation

hengfengli
Copy link
Contributor

@hengfengli hengfengli commented Jul 14, 2021

Two changes:

  • Add row.String()
  • Refine the error message for decoding a struct array

@hengfengli hengfengli added the api: spanner Issues related to the Cloud Spanner API. label Jul 14, 2021
@hengfengli hengfengli requested a review from olavloite Jul 14, 2021
@hengfengli hengfengli self-assigned this Jul 14, 2021
@hengfengli hengfengli requested review from skuruppu and a team as code owners Jul 14, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2021
Copy link
Contributor

@olavloite olavloite left a comment

LGTM, but I think the commit message should start with feat instead of fix. This is not really a bug that is being fixed, but a feature that was missing that is being added.

@hengfengli hengfengli changed the title fix(spanner): add row.String() and refine error message for decoding a struct array feat(spanner): add row.String() and refine error message for decoding a struct array Jul 14, 2021
@hengfengli
Copy link
Contributor Author

hengfengli commented Jul 14, 2021

@skuruppu Can I get an approval from you?

@hengfengli hengfengli merged commit f6258a4 into googleapis:master Jul 15, 2021
4 checks passed
@hengfengli hengfengli deleted the refine-row-to-struct branch Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants