Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/godocfx): set exit code, print cmd output, no go get ... #4445

merged 1 commit into from Jul 15, 2021


Copy link

@tbpg tbpg commented Jul 15, 2021

The command was failing, but the job was succeeding. These changes:

  • Fix the underlying issue (...).
  • Print cmd output to make debugging easier.
  • Set an exit code.

@tbpg tbpg requested a review from codyoss July 15, 2021 13:37
@tbpg tbpg requested a review from a team as a code owner July 15, 2021 13:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2021
Copy link

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tbpg tbpg merged commit cc70f77 into master Jul 15, 2021
@tbpg tbpg deleted the godocfx branch July 15, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes This human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants