Skip to content

fix(internal/godocfx): set exit code, print cmd output, no go get ...#4445

Merged
tbpg merged 1 commit intomasterfrom
godocfx
Jul 15, 2021
Merged

fix(internal/godocfx): set exit code, print cmd output, no go get ...#4445
tbpg merged 1 commit intomasterfrom
godocfx

Conversation

@tbpg
Copy link
Copy Markdown
Contributor

@tbpg tbpg commented Jul 15, 2021

The command was failing, but the job was succeeding. These changes:

  • Fix the underlying issue (...).
  • Print cmd output to make debugging easier.
  • Set an exit code.

@tbpg tbpg requested review from a team and codyoss July 15, 2021 13:37
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2021
codyoss
codyoss approved these changes Jul 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tbpg tbpg merged commit cc70f77 into master Jul 15, 2021
@tbpg tbpg deleted the godocfx branch July 15, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyoss codyoss codyoss approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tbpg @codyoss