Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): detect module for properly generating docs URLs #4460

Merged
merged 3 commits into from
Jul 20, 2021
Merged

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jul 19, 2021

Fixes: #4447

@codyoss codyoss requested a review from tbpg July 19, 2021 19:53
@codyoss codyoss requested a review from a team as a code owner July 19, 2021 19:53
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 19, 2021
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Jul 19, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 20, 2021
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I'm not sure how we should handle unreleased packages. We also need to handle packages that move from one module to another. But, those are separate issues.

@tbpg tbpg added the automerge Merge the pull request once unit tests and other checks pass. label Jul 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1eaba8b into googleapis:master Jul 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 20, 2021
@codyoss codyoss deleted the meta-fix branch September 11, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all: repo metadata incorrect for submodules
2 participants