Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/gapicgen): exec Stdout already set #4509

Merged
merged 2 commits into from
Jul 28, 2021
Merged

fix(internal/gapicgen): exec Stdout already set #4509

merged 2 commits into from
Jul 28, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jul 28, 2021

This error was occuring because stdout was being set by some
calling locations which violates Command.Output usage. This
refactors code to never set stdout. I also added some more debug
info of logging the command output which can be useful in the case
of failures.

This error was occuring because stdout was being set by some
calling locations which violates Command.Output usage. This
refactors code to never set stdout. I also added some more debug
info of logging the command output which can be useful in the case
of failures.
@codyoss codyoss requested a review from a team as a code owner July 28, 2021 20:12
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2021
@codyoss codyoss requested a review from noahdietz July 28, 2021 20:12
@codyoss codyoss merged commit 41246e9 into googleapis:master Jul 28, 2021
@codyoss codyoss deleted the fix-stdout-err branch July 28, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants