fix(internal/gapicgen): exec Stdout already set#4509
Merged
codyoss merged 2 commits intogoogleapis:masterfrom Jul 28, 2021
codyoss:fix-stdout-err
Merged
fix(internal/gapicgen): exec Stdout already set#4509codyoss merged 2 commits intogoogleapis:masterfrom codyoss:fix-stdout-err
codyoss merged 2 commits intogoogleapis:masterfrom
codyoss:fix-stdout-err
Conversation
This error was occuring because stdout was being set by some calling locations which violates Command.Output usage. This refactors code to never set stdout. I also added some more debug info of logging the command output which can be useful in the case of failures.
google-cla
Bot
added
the
cla: yes
noahdietz
approved these changes
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error was occuring because stdout was being set by some
calling locations which violates Command.Output usage. This
refactors code to never set stdout. I also added some more debug
info of logging the command output which can be useful in the case
of failures.