Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/carver): don't tag commits #4518

Merged
merged 3 commits into from
Jul 30, 2021
Merged

fix(internal/carver): don't tag commits #4518

merged 3 commits into from
Jul 30, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jul 29, 2021

After running some simulations in became apparent that the tool
should not tags commits. This is because when merging the sha
will change. The tool now outputs a template for the commands
to run post merge.

@codyoss codyoss requested a review from tbpg July 29, 2021 22:13
@codyoss codyoss requested a review from a team as a code owner July 29, 2021 22:13
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2021
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Jul 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c355eb8 into googleapis:master Jul 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 30, 2021
@codyoss codyoss deleted the carver-update-2 branch September 11, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants