feat(.github): support dynamic submodule detection#4537
Merged
codyoss merged 7 commits intogoogleapis:masterfrom Aug 5, 2021
codyoss:go-actions
Merged
feat(.github): support dynamic submodule detection#4537codyoss merged 7 commits intogoogleapis:masterfrom codyoss:go-actions
codyoss merged 7 commits intogoogleapis:masterfrom
codyoss:go-actions
Conversation
Today the sub-modules are are coded into a couple of places to work with release-please. This change is the first of three to make release-please automatically support newly added modules.
google-cla
bot
added
the
cla: yes
tbpg
reviewed
Aug 2, 2021
| @@ -0,0 +1,3 @@ | |||
| module cloud.google.com/go/internal/actions | |||
Contributor
There was a problem hiding this comment.
Why do we need a separate module for this?
Member
Author
There was a problem hiding this comment.
Technically no, but if I want to keep using newer io.FS apis, yes.
codyoss
added
the
automerge
tbpg
approved these changes
Aug 4, 2021
codyoss
added
automerge
gcf-merge-on-green
bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today the sub-modules are are coded into a couple of places to
work with release-please. This change is the first of three to
make release-please automatically support newly added modules.
Also, the workflow step was refactored to be in Go which makes
the code easier to test and debug locally in my opinion.