feat(compute)!: add pagination and an Operation wrapper #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
codyoss
approved these changes
Aug 3, 2021
|
Force merging. This broke samples in a known way. This code is currently considered alpha. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does multiple things due to the breaking nature of the code changes for
compute.Breaking changes:
Operationtype instead of the protobuf-go generated type directlyIntegration tests are added for all of the new changes.
The gapic generator is updated with the aforementioned changes. To enable these changes,
genbotwill now supply thediregapicflag to the gapic generator based on if the API is generated viagoogleapis-discovery.