Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compute)!: add pagination and an Operation wrapper #4542

merged 10 commits into from Aug 3, 2021


Copy link

@noahdietz noahdietz commented Aug 2, 2021

This PR does multiple things due to the breaking nature of the code changes for compute.

Breaking changes:

  • paginated APIs now return Iterators
  • long running APIs now return a wrapped Operation type instead of the protobuf-go generated type directly

Integration tests are added for all of the new changes.

The gapic generator is updated with the aforementioned changes. To enable these changes, genbot will now supply the diregapic flag to the gapic generator based on if the API is generated via googleapis-discovery.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2021
@noahdietz noahdietz marked this pull request as ready for review August 3, 2021 19:42
@noahdietz noahdietz requested a review from a team as a code owner August 3, 2021 19:42
Copy link

codyoss commented Aug 3, 2021

Force merging. This broke samples in a known way. This code is currently considered alpha.

@codyoss codyoss merged commit 36f4649 into googleapis:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes This human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants