Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/godocfx): add status to packages and TOCs #4547

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Aug 3, 2021

Follow up from #4525.

@tbpg tbpg requested a review from a team as a code owner August 3, 2021 11:17
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tbpg tbpg added the automerge Merge the pull request once unit tests and other checks pass. label Aug 3, 2021
Copy link

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add other Status other than Deprecated, would that cause any of the other statuses to show because of googleapis/doc-templates#247? I'm guessing not because we specifically look for {{#deprecated}}?

@tbpg
Copy link
Contributor Author

tbpg commented Aug 3, 2021

If we add other Status other than Deprecated, would that cause any of the other statuses to show

Yes. The TOC plumbs through any status value. However, the alpha and beta statuses are not used for main doc content.

@tbpg tbpg merged commit c6de69c into master Aug 3, 2021
@tbpg tbpg deleted the godocfx-pkg-status branch August 3, 2021 15:19
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants