Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner/spansql): only add comma after other option #4551

Merged
merged 2 commits into from Aug 5, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Aug 4, 2021

Only add a comma to the options list if at least one other preceding option has been set.

Fixes #4550

@olavloite olavloite requested a review from hengfengli Aug 4, 2021
@olavloite olavloite requested review from skuruppu and a team as code owners Aug 4, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 4, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Aug 4, 2021
@olavloite
Copy link
Contributor Author

olavloite commented Aug 4, 2021

The build error is caused by a failure in one of the samples for Google Compute, and so is unrelated to this change.

@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2021
@hengfengli
Copy link
Contributor

hengfengli commented Aug 4, 2021

@codyoss An unrelated test fails. Can we fix it to unblock this PR?

@codyoss
Copy link
Member

codyoss commented Aug 4, 2021

@hengfengli I just raised GoogleCloudPlatform/golang-samples#2174 to unblock this.

@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2021
@hengfengli hengfengli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2021
@hengfengli hengfengli merged commit 3ac1e00 into master Aug 5, 2021
5 checks passed
@hengfengli hengfengli deleted the issue-4550 branch Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner/spansql: (*AlterDatabase).SQL() includes incorrect commas
4 participants