Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner): allow decoding null values to spanner.Decoder #4558

Merged
merged 2 commits into from Aug 5, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Aug 5, 2021

Allow NULL values from the database to be passed in to the DecodeSpanner method
of a struct that implements spanner.Decoder.

Fixes #4552

olavloite added 2 commits Aug 5, 2021
Allow NULL values from the database to be passed in to the DecodeSpanner method
of a struct that implements spanner.Decoder.

Fixes #4552
@olavloite olavloite requested a review from hengfengli Aug 5, 2021
@olavloite olavloite requested review from skuruppu and a team as code owners Aug 5, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Aug 5, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2021
Copy link
Contributor

@hengfengli hengfengli left a comment

LGTM. Thanks for the fix.

@olavloite olavloite merged commit 45ddaca into master Aug 5, 2021
5 checks passed
@olavloite olavloite deleted the issue-4552 branch Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: Can not decode Null value to user defined custom type with DecodeSpanner
2 participants