Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner/spannertest): Fix the "LIKE" clause handling for forward and backward matches #4655

Conversation

sryoya
Copy link
Contributor

@sryoya sryoya commented Aug 20, 2021

Fixes #4654

@sryoya sryoya requested review from hengfengli, skuruppu and a team as code owners Aug 20, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Aug 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 20, 2021
@codyoss codyoss changed the title fix(spannertest): Fix the "LIKE" clause handling for forward and backward matches fix(spanner/spannertest): Fix the "LIKE" clause handling for forward and backward matches Aug 20, 2021
@hengfengli hengfengli requested a review from olavloite Aug 23, 2021
Copy link
Contributor

@olavloite olavloite left a comment

Nice find, LGTM

@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
@hengfengli hengfengli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
@hengfengli hengfengli merged commit a2118f0 into googleapis:master Aug 23, 2021
4 checks passed
@sryoya sryoya deleted the fix_LIKE_clause_handling_for_prefix_and_suffix branch Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
4 participants