Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(civil): add IsEmpty function to time, date and datetime #4728

Merged
merged 5 commits into from
Sep 28, 2021
Merged

feat(civil): add IsEmpty function to time, date and datetime #4728

merged 5 commits into from
Sep 28, 2021

Conversation

Qalifah
Copy link
Contributor

@Qalifah Qalifah commented Sep 5, 2021

No description provided.

@Qalifah Qalifah requested a review from a team as a code owner September 5, 2021 08:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 5, 2021
@codyoss
Copy link
Member

codyoss commented Sep 9, 2021

@Qalifah Can you please raise an issue for this feature request for discussion. We generally like to talk things through before accepting PRs, thanks!

@codyoss codyoss added do not merge Indicates a pull request not ready for merge, due to either quality or timing. needs more info This issue needs more information from the customer to proceed. labels Sep 9, 2021
@Qalifah
Copy link
Contributor Author

Qalifah commented Sep 9, 2021

@Qalifah Can you please raise an issue for this feature request for discussion. We generally like to talk things through before accepting PRs, thanks!

I did that #4727

codyoss
codyoss requested changes Sep 14, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions, thanks for the PR.

civil/civil.go Outdated Show resolved Hide resolved
civil/civil.go Outdated Show resolved Hide resolved
@codyoss codyoss changed the title feat: add IsEmpty function to time, date and datetime feat(civil): add IsEmpty function to time, date and datetime Sep 14, 2021
@codyoss codyoss removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. needs more info This issue needs more information from the customer to proceed. labels Sep 14, 2021
codyoss
codyoss reviewed Sep 14, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more small thing.

civil/civil.go Outdated Show resolved Hide resolved
codyoss
codyoss approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@codyoss codyoss added automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 28, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2021
@codyoss codyoss removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Sep 28, 2021
@codyoss codyoss merged commit 88bfa64 into googleapis:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qalifah @codyoss @kokoro-team