Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spansql): Support multiple joins in query #4743

Merged
merged 4 commits into from Sep 14, 2021

Conversation

philwitty
Copy link
Contributor

@philwitty philwitty commented Sep 10, 2021

#3966 is implementing the same functionality (and more) but the author has lost interest and I don't have the knowledge to take over the unnest parts of his PR, I felt my solution to multiple joins is simple enough the other functionality could be rebased on top of it assuming a new owner takes it on.

@philwitty philwitty requested review from hengfengli, skuruppu and a team as code owners Sep 10, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Sep 10, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 10, 2021
@hengfengli hengfengli requested a review from olavloite Sep 13, 2021
Copy link
Contributor

@olavloite olavloite left a comment

This looks good to me. Would you mind adding a test case for LEFT JOIN as well, just to be sure we don't add any regressions in the future?

@@ -1109,6 +1109,13 @@ func TestIntegration_ReadsAndQueries(t *testing.T) {
{int64(4), nil, "p"},
},
},
{
Copy link
Contributor

@olavloite olavloite Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could we also add a LEFT JOIN test here? I've verified that it does work, but adding a test case could prevent potential regressions in the future.

@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2021
Copy link
Contributor

@olavloite olavloite left a comment

Thanks a lot for working on this. LGTM.

@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Sep 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 81a308e into googleapis:master Sep 14, 2021
4 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 14, 2021
@philwitty philwitty deleted the multiple-joins branch Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner/spansql: Multiple Joins support?
4 participants