Skip to content

fix(compute/metadata): remove heavy gax dependency#4784

Merged
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:masterfrom
codyoss:reduce-bin-size
Sep 21, 2021
Merged

fix(compute/metadata): remove heavy gax dependency#4784
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:masterfrom
codyoss:reduce-bin-size

Conversation

@codyoss
Copy link
Copy Markdown
Member

@codyoss codyoss commented Sep 21, 2021

Because of how the gax package is structured today it ends up
pulling in proto and gRPC which can add a lot of extra deps to the
tree if all you really need is this package.

Fixes: #4783

Because of how the gax package is structured today it ends up
pulling in proto and gRPC which can add a lot of extra deps to the
tree if all you really need is this package.

Fixes: #4783
@codyoss codyoss requested a review from a team September 21, 2021 15:24
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Sep 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2021
@codyoss codyoss requested review from noahdietz and tbpg September 21, 2021 15:25
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Sep 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit ea00264 into googleapis:master Sep 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 21, 2021
@codyoss codyoss deleted the reduce-bin-size branch September 21, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compute/metadata: binary size increase by 6.5Mb after the commit 81c6039503121f8da3de4f4cd957b8488a3ef620

2 participants