Skip to content

fix(internal/trace): use xerrors.As for trace#4813

Merged
codyoss merged 1 commit intogoogleapis:masterfrom
tritone:error-as-trace
Sep 27, 2021
Merged

fix(internal/trace): use xerrors.As for trace#4813
codyoss merged 1 commit intogoogleapis:masterfrom
tritone:error-as-trace

Conversation

@tritone
Copy link
Copy Markdown
Contributor

@tritone tritone commented Sep 24, 2021

Based on #4797, we should use xerrors.As for googleapi errors.

Based on googleapis#4797, we should use xerrors.As for googleapi errors.
@tritone tritone requested a review from a team September 24, 2021 20:09
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2021
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss merged commit 05fe61c into googleapis:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants