Skip to content

feat(internal/godocfx): detect preview versions#4899

Merged
tbpg merged 1 commit intomasterfrom
godocfx
Sep 28, 2021
Merged

feat(internal/godocfx): detect preview versions#4899
tbpg merged 1 commit intomasterfrom
godocfx

Conversation

@tbpg
Copy link
Copy Markdown
Contributor

@tbpg tbpg commented Sep 28, 2021

See b/197007831.

I added unit tests. But, I also confirmed this works on google.golang.org/appengine/v2 (status: preview shows up in the output YAML).

@tbpg tbpg requested review from a team and codyoss September 28, 2021 15:56
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2021
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbpg tbpg merged commit 9b60844 into master Sep 28, 2021
@tbpg tbpg deleted the godocfx branch September 28, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants