Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spansql): support JSON data type #4959

Merged
merged 2 commits into from Oct 8, 2021
Merged

feat(spanner/spansql): support JSON data type #4959

merged 2 commits into from Oct 8, 2021

Conversation

rahul2393
Copy link
Contributor

@rahul2393 rahul2393 commented Oct 7, 2021

This adds support for JSON as a column data type in CREATE TABLE and
similar constructions. Its support in spannertest remains a TODO.

Fixes #4906.

@rahul2393 rahul2393 requested review from hengfengli, skuruppu and a team as code owners Oct 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Oct 7, 2021
@rahul2393
Copy link
Contributor Author

rahul2393 commented Oct 7, 2021

@codyoss Does this look good to you?

@hengfengli hengfengli requested a review from olavloite Oct 7, 2021
Copy link
Contributor

@olavloite olavloite left a comment

This looks good purely for parsing CREATE/ALTER TABLE statements that add JSON columns. Those JSON columns are however not usable, which also includes for example executing a SELECT * FROM Table on a table with a JSON column. From what I understand in the referenced issue, and also from the note in the general description, that is an acceptable and known TODO.

@rahul2393 rahul2393 merged commit e84e408 into googleapis:master Oct 8, 2021
4 checks passed
@geerttouquet
Copy link

geerttouquet commented Oct 8, 2021

thanks for the change that is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner/spansql: support for JSON type in a table
4 participants