Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spannertest): implement RowDeletionPolicy in spannertest #4961

Merged
merged 4 commits into from Oct 8, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Oct 7, 2021

Fixes #4782

@olavloite olavloite requested a review from hengfengli Oct 7, 2021
@olavloite olavloite requested review from skuruppu and a team as code owners Oct 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2021
@olavloite olavloite changed the title feat: implement RowDeletionPolicy in spannertest feat(spanner/spannertest): implement RowDeletionPolicy in spannertest Oct 7, 2021
@hengfengli hengfengli requested a review from rahul2393 Oct 7, 2021
Copy link
Contributor

@rahul2393 rahul2393 left a comment

LGTM

@olavloite olavloite added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Oct 7, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2021
@olavloite olavloite removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2021
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Oct 8, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7800a33 into master Oct 8, 2021
5 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the spannertest-row-deletion-policy branch Oct 8, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spannertest: add support for row deletion policy
4 participants