Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spansql): support CAST and SAFE_CAST #5057

Merged
merged 5 commits into from Nov 3, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Nov 1, 2021

Adds support for the CAST and SAFE_CAST functions. This change also includes a small refactor of the function evaluation to allow the function evaluation to receive type information for the arguments. This makes it easier to implement conversion functions.

olavloite added 2 commits Nov 1, 2021
Adds support for the CAST and SAFE_CAST functions. This change also includes
a small refactor of the function evaluation to allow the function evaluation to
receive both parsing errors and type information for the arguments. This makes
it easier to implement the SAFE versions of the functions.
@olavloite olavloite requested review from hengfengli and rahul2393 Nov 1, 2021
@olavloite olavloite requested review from skuruppu and a team as code owners Nov 1, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Nov 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2021
@olavloite
Copy link
Contributor Author

olavloite commented Nov 1, 2021

cc @yokoyama10

@olavloite olavloite merged commit 54cbf4c into master Nov 3, 2021
5 checks passed
@olavloite olavloite deleted the spansql-cast-function branch Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants