fix(compute/metadata): return an error when all retries have failed

[Deiz]

Minor change to ensure an error is returned to the caller when all retries have failed.

Fixes #5062

[codyoss]

LGTM, thank you for the error report and contribution!

[codyoss]

@Deiz Would you mind updating the PR. This repo is decently high traffic and can be hard to land things in sometimes. If you tick the box allow edits from maintains I can help update and get this is. Thanks!

[Deiz]

Have at it 🙂

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

[gcf-merge-on-green]

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

[gcf-merge-on-green]

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.