Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiler): refine regular expression for parsing backoff duration in e2e tests #5229

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

nolanmar511
Copy link
Contributor

Some structured log messages included unrelated substrings which matched the back off duration regexp, leading to backoff integration tests to fail. This change refines the regexp so that will not happen.

@nolanmar511 nolanmar511 requested a review from a team as a code owner December 20, 2021 23:48
@product-auto-label product-auto-label bot added the api: cloudprofiler Issues related to the Cloud Profiler API. label Dec 20, 2021
@nolanmar511 nolanmar511 enabled auto-merge (squash) December 20, 2021 23:51
@nolanmar511 nolanmar511 merged commit 4438aeb into googleapis:main Dec 21, 2021
BrennaEpp pushed a commit to BrennaEpp/google-cloud-go that referenced this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudprofiler Issues related to the Cloud Profiler API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants