Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): Add ReadRowWithOptions method #5240

Merged
merged 2 commits into from Dec 29, 2021

Conversation

shuheiktgw
Copy link
Contributor

@shuheiktgw shuheiktgw commented Dec 21, 2021

Currently, there are no ways users can provide ReadOptions to the ReadRow method. It would be great if we have a method for that purpose so I've added a new method called ReadRowWithOptions. I could not find tests for the ReadRow method so would you guide me on where to add tests for the new method? Thank you!

@shuheiktgw shuheiktgw requested review from a team as code owners Dec 21, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Dec 21, 2021
@shuheiktgw shuheiktgw force-pushed the spanner_read_row_with_options branch from 96afde1 to 1605b95 Compare Dec 21, 2021
@hengfengli hengfengli requested a review from rahul2393 Dec 21, 2021
@rahul2393
Copy link
Contributor

rahul2393 commented Dec 22, 2021

Thanks @shuheiktgw for creating the PR, you can add test by referring to this test https://github.com/googleapis/google-cloud-go/blob/main/spanner/client_test.go#L2839

@shuheiktgw shuheiktgw force-pushed the spanner_read_row_with_options branch from b81a887 to 8ad7136 Compare Dec 24, 2021
@shuheiktgw
Copy link
Contributor Author

shuheiktgw commented Dec 24, 2021

@rahul2393 thanks for pointing it out! I've added a test for the ReadRowWithOptions so would you review the PR please? 🙏

Copy link
Contributor

@rahul2393 rahul2393 left a comment

LGTM

@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 29, 2021
@rahul2393 rahul2393 merged commit c276428 into googleapis:main Dec 29, 2021
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants