From 6ff8b4494546f23515358bcbf030f856ba4dd1c3 Mon Sep 17 00:00:00 2001 From: BrennaEpp Date: Wed, 7 Feb 2024 17:16:34 -0800 Subject: [PATCH 1/2] docs(storage): indicate that gRPC is incompatible with universe domains --- storage/storage.go | 1 + 1 file changed, 1 insertion(+) diff --git a/storage/storage.go b/storage/storage.go index b000325febf1..0165b496abd9 100644 --- a/storage/storage.go +++ b/storage/storage.go @@ -219,6 +219,7 @@ func NewClient(ctx context.Context, opts ...option.ClientOption) (*Client, error // NewGRPCClient creates a new Storage client using the gRPC transport and API. // Client methods which have not been implemented in gRPC will return an error. // In particular, methods for Cloud Pub/Sub notifications are not supported. +// Using a non-default universe domain is also not supported in gRPC. // // The storage gRPC API is still in preview and not yet publicly available. // If you would like to use the API, please first contact your GCP account rep to From 0a8b03294ff4ea3cee28f3750da6df98a05a1fd1 Mon Sep 17 00:00:00 2001 From: BrennaEpp Date: Thu, 8 Feb 2024 10:14:46 -0800 Subject: [PATCH 2/2] suggestion --- storage/storage.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/storage/storage.go b/storage/storage.go index 0165b496abd9..49e8cb3dbbe9 100644 --- a/storage/storage.go +++ b/storage/storage.go @@ -219,7 +219,8 @@ func NewClient(ctx context.Context, opts ...option.ClientOption) (*Client, error // NewGRPCClient creates a new Storage client using the gRPC transport and API. // Client methods which have not been implemented in gRPC will return an error. // In particular, methods for Cloud Pub/Sub notifications are not supported. -// Using a non-default universe domain is also not supported in gRPC. +// Using a non-default universe domain is also not supported with the Storage +// gRPC client. // // The storage gRPC API is still in preview and not yet publicly available. // If you would like to use the API, please first contact your GCP account rep to