Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

GrpcTransportOptions uses internal grpc APIs #120

Closed
ejona86 opened this issue Jul 22, 2019 · 3 comments
Closed

GrpcTransportOptions uses internal grpc APIs #120

ejona86 opened this issue Jul 22, 2019 · 3 comments
Assignees
@meltsufin
Labels
semver: patch A minor bug fix or small change. type: cleanup An internal cleanup or hygiene concern.

Comments

@ejona86
Copy link

ejona86 commented Jul 22, 2019

GrpcTransportOptions references io.grpc.internal.SharedResourceHolder. As it is in the internal package, it has an unstable API that may change at any time.

https://github.com/googleapis/google-cloud-java/blob/6b567115e98271632bdaa04833fdd9e217bd9c3e/google-cloud-clients/google-cloud-core-grpc/src/main/java/com/google/cloud/grpc/GrpcTransportOptions.java#L35-L36
@chingor13 chingor13 self-assigned this Jul 24, 2019
@chingor13 chingor13 transferred this issue from googleapis/google-cloud-java Jan 7, 2020
@chingor13 chingor13 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 7, 2020
@chingor13 chingor13 mentioned this issue Jan 10, 2020
Closed
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jan 18, 2020
@elharo elharo added semver: patch A minor bug fix or small change. type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 30, 2020
@chingor13 chingor13 removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jan 30, 2020
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jan 31, 2020
@chingor13 chingor13 assigned Neenu1995 and unassigned chingor13 Sep 8, 2021
@Neenu1995 Neenu1995 assigned meltsufin and unassigned Neenu1995 Jul 25, 2022
@meltsufin
Copy link
Member

It's only used in an internal api of java-core. So, it should be safe in case it has to change. Please re-open, if needed.

@ejona86
Copy link
Author

ejona86 commented Jul 25, 2022 •
edited

Please re-open.

No, this isn't about whether the API is exposed to your users. Libraries must not use unstable APIs in other libraries as libraries cannot dictate which version of other libraries are being used (they can choose a minimum version, but not a specific version).

@meltsufin
Copy link
Member

@chingor13 You had a PR open to fix it, but you closed it. Why?

@ejona86 ejona86 mentioned this issue Nov 4, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meltsufin meltsufin

Labels
semver: patch A minor bug fix or small change. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: stop using internal gRPC classes googleapis/java-core
6 participants
@chingor13 @elharo @ejona86 @Neenu1995 @meltsufin @yoshi-automation