From 59729e9e42e8415549300f34492bd386761103c4 Mon Sep 17 00:00:00 2001 From: Garrett Jones Date: Mon, 21 Aug 2017 09:12:23 -0700 Subject: [PATCH] Update sink: expecting exception --- .../google/cloud/logging/BaseSystemTest.java | 22 +++++-------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java b/google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java index 2049d679740a..6560ece9ad7d 100644 --- a/google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java +++ b/google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java @@ -148,14 +148,9 @@ public void testUpdateNonExistingSink() { .setVersionFormat(SinkInfo.VersionFormat.V2) .build(); assertNull(logging().getSink(name)); - Sink sink = logging().update(sinkInfo); - assertEquals(name, sink.getName()); - assertEquals(SinkInfo.VersionFormat.V2, sink.getVersionFormat()); - assertEquals("severity>=ERROR", sink.getFilter()); - DatasetDestination datasetDestination = sink.getDestination(); - assertEquals(logging().getOptions().getProjectId(), datasetDestination.getProject()); - assertEquals("dataset", datasetDestination.getDataset()); - assertTrue(logging().deleteSink(name)); + thrown.expect(LoggingException.class); + thrown.expectMessage("NOT_FOUND"); + logging().update(sinkInfo); } @Test @@ -166,14 +161,9 @@ public void testUpdateNonExistingSinkAsync() throws ExecutionException, Interrup .setVersionFormat(SinkInfo.VersionFormat.V2) .build(); assertNull(logging().getSinkAsync(name).get()); - Sink sink = logging().updateAsync(sinkInfo).get(); - assertEquals(name, sink.getName()); - assertEquals(SinkInfo.VersionFormat.V2, sink.getVersionFormat()); - assertEquals("severity>=ERROR", sink.getFilter()); - DatasetDestination datasetDestination = sink.getDestination(); - assertEquals(logging().getOptions().getProjectId(), datasetDestination.getProject()); - assertEquals("dataset", datasetDestination.getDataset()); - assertTrue(logging().deleteSinkAsync(name).get()); + thrown.expect(ExecutionException.class); + thrown.expectMessage("NOT_FOUND"); + logging().updateAsync(sinkInfo).get(); } @Test