New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue/pr templates #3794

Merged
merged 4 commits into from Oct 11, 2018

Conversation

Projects
None yet
3 participants
@chingor13
Collaborator

chingor13 commented Oct 9, 2018

Fixes #3791

@chingor13 chingor13 requested a review from googleapis/yoshi-java Oct 9, 2018

@chingor13 chingor13 requested a review from pongad as a code owner Oct 9, 2018

@googlebot googlebot added the cla: yes label Oct 9, 2018

@elharo

In general, aim for shorter and more formal.

@@ -0,0 +1,30 @@
Thanks for stopping by to let us know something could be better!
Please be sure to include as much information as possible:

This comment has been minimized.

@elharo

elharo Oct 10, 2018

Collaborator

delete "be sure to"

This comment has been minimized.

@chingor13

chingor13 Oct 10, 2018

Collaborator

done.

@@ -0,0 +1,4 @@
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)
- [ ] Tests pass

This comment has been minimized.

@elharo

elharo Oct 10, 2018

Collaborator

As a frequent external contributor I find these annoying. Manually running tests is not as reliable as the CI, and it's often hard to figure out exactly where and how docs should be updated. For instance, does it include docs on cloud.google.com in piper? It's more reliable for the code owner who presumable knows how the docs are set up to simply look at the PR to see if it includes the docs changes they expect.

This comment has been minimized.

@chingor13

chingor13 Oct 10, 2018

Collaborator

Ok, we'll remove the todo list for now and revisit if the quality of PR drops.

#### Any additional information below
Making sure to follow these steps will guarantee the quickest resolution possible.

This comment has been minimized.

@elharo

elharo Oct 10, 2018

Collaborator

Making sure to follow --> Following

This comment has been minimized.

@chingor13

chingor13 Oct 10, 2018

Collaborator

done

@elharo

elharo approved these changes Oct 11, 2018

@chingor13 chingor13 merged commit d230eca into googleapis:master Oct 11, 2018

7 checks passed

Kokoro - Integration Tests Build successful
Details
Kokoro - Test: Java 7 Build successful
Details
Kokoro - Test: Java 8 Build successful
Details
Kokoro - Test: Javadoc Build successful
Details
Kokoro - Test: OSX Java 8 Build successful
Details
Kokoro - Test: Windows Java 8 Build successful
Details
cla/google All necessary CLAs are signed

@chingor13 chingor13 deleted the chingor13:issue-templates branch Oct 11, 2018

@JesseLovelace JesseLovelace referenced this pull request Oct 25, 2018

Merged

Release v0.68.0 #3857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment