New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify release process #3799

Merged
merged 6 commits into from Oct 10, 2018

Conversation

Projects
None yet
3 participants
@chingor13
Collaborator

chingor13 commented Oct 10, 2018

These maven config changes make it so you no longer need to edit the root pom.xml file as part of the release process.

  • Moved the gpg signing and nexus-sonatype-staging-plugin to the artifacts that are releasable. This plugin replaces the deploy goal.
  • Skip maven-deploy-plugin for non-releasable artifacts.
  • Changes order of modules because a deployable artifact must be last.

chingor13 added some commits Oct 9, 2018

Only deploy the deployable artifacts.
Only use the nexus-staging-maven-plugin on deployable assets.
Set skip to true for deployment on non-deployable assets.

@chingor13 chingor13 requested review from garrettjonesgoogle and googleapis/yoshi-java Oct 10, 2018

@chingor13 chingor13 requested a review from pongad as a code owner Oct 10, 2018

@googlebot googlebot added the cla: yes label Oct 10, 2018

@@ -679,7 +669,7 @@
<violationSeverity>error</violationSeverity>
<failsOnError>true</failsOnError>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<excludes>com/google/cloud/*/v*/**</excludes><!-- We need to exclude autogenerated code -->
<excludes>com/google/cloud/*/v*/**,</excludes><!-- We need to exclude autogenerated code -->

This comment has been minimized.

@garrettjonesgoogle

garrettjonesgoogle Oct 10, 2018

Member

Why a new comma here?

This comment has been minimized.

@chingor13

chingor13 Oct 10, 2018

Collaborator

Ah - I had tried adding a new value and reverted, but missed the comma. There was an issue with license headers if you run tests during the release, but the process skips the tests (they should be verified prior to releasing).

I'll remove

@chingor13 chingor13 merged commit 76e09ee into googleapis:master Oct 10, 2018

7 checks passed

Kokoro - Integration Tests Build successful
Details
Kokoro - Test: Java 7 Build successful
Details
Kokoro - Test: Java 8 Build successful
Details
Kokoro - Test: Javadoc Build successful
Details
Kokoro - Test: OSX Java 8 Build successful
Details
Kokoro - Test: Windows Java 8 Build successful
Details
cla/google All necessary CLAs are signed

@chingor13 chingor13 deleted the chingor13:release-profile branch Oct 10, 2018

This was referenced Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment