From 22f8ff330b88b65ff28a4dbd13226cba86dbbefe Mon Sep 17 00:00:00 2001 From: Justin Beckwith Date: Wed, 5 Sep 2018 07:08:00 -0700 Subject: [PATCH] Enable noImplicitThis in tsconfig (#115) Resolves #69 --- packages/google-cloud-translate/test/index.ts | 12 ++++++++---- packages/google-cloud-translate/tsconfig.json | 3 +-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/packages/google-cloud-translate/test/index.ts b/packages/google-cloud-translate/test/index.ts index dbf50b9a1f5..65f6acc98dc 100644 --- a/packages/google-cloud-translate/test/index.ts +++ b/packages/google-cloud-translate/test/index.ts @@ -47,8 +47,12 @@ const fakeUtil = extend({}, util, { }); const originalFakeUtil = extend(true, {}, fakeUtil); -function FakeService() { - this.calledWith_ = arguments; +class FakeService { + calledWith_: IArguments; + request?: Function; + constructor() { + this.calledWith_ = arguments; + } } describe('Translate', () => { @@ -525,10 +529,10 @@ describe('Translate', () => { describe('request', () => { describe('OAuth mode', () => { - let request: r.Request; + let request: Function; beforeEach(() => { - request = FakeService.prototype.request; + request = FakeService.prototype.request!; }); afterEach(() => { diff --git a/packages/google-cloud-translate/tsconfig.json b/packages/google-cloud-translate/tsconfig.json index 9cc6883089f..b10ee498aef 100644 --- a/packages/google-cloud-translate/tsconfig.json +++ b/packages/google-cloud-translate/tsconfig.json @@ -2,8 +2,7 @@ "extends": "./node_modules/gts/tsconfig-google.json", "compilerOptions": { "rootDir": ".", - "outDir": "build", - "noImplicitThis": false + "outDir": "build" }, "include": [ "src/*.ts",