diff --git a/packages/google-cloud-run/.repo-metadata.json b/packages/google-cloud-run/.repo-metadata.json index 2ad236f2b0a..40477f213d4 100644 --- a/packages/google-cloud-run/.repo-metadata.json +++ b/packages/google-cloud-run/.repo-metadata.json @@ -2,7 +2,7 @@ "name": "run", "name_pretty": "Cloud Run", "product_documentation": "https://cloud.google.com/run", - "client_documentation": "https://cloud.google.com/nodejs/docs/reference/run/latest", + "client_documentation": "https://googleapis.dev/nodejs/run/latest", "issue_tracker": "https://github.com/googleapis/nodejs-run/issues", "release_level": "beta", "language": "nodejs", diff --git a/packages/google-cloud-run/README.md b/packages/google-cloud-run/README.md index 187fbead40a..7f96418ce3e 100644 --- a/packages/google-cloud-run/README.md +++ b/packages/google-cloud-run/README.md @@ -175,7 +175,7 @@ Apache Version 2.0 See [LICENSE](https://github.com/googleapis/nodejs-run/blob/main/LICENSE) -[client-docs]: https://cloud.google.com/nodejs/docs/reference/run/latest +[client-docs]: https://googleapis.dev/nodejs/run/latest [product-docs]: https://cloud.google.com/run [shell_img]: https://gstatic.com/cloudssh/images/open-btn.png [projects]: https://console.cloud.google.com/project diff --git a/packages/google-cloud-run/src/v2/services_client.ts b/packages/google-cloud-run/src/v2/services_client.ts index e9add88db04..5ec6413c219 100644 --- a/packages/google-cloud-run/src/v2/services_client.ts +++ b/packages/google-cloud-run/src/v2/services_client.ts @@ -1013,16 +1013,15 @@ export class ServicesClient { options.otherArgs = options.otherArgs || {}; options.otherArgs.headers = options.otherArgs.headers || {}; const routingParameter = {}; + const reqService = request.service || {}; if ( - typeof request.service?.name !== 'undefined' && + typeof reqService.name !== 'undefined' && RegExp('projects/[^/]+/locations/(?[^/]+)(?:/.*)?').test( - request.service.name! + reqService.name! ) ) { Object.assign(routingParameter, { - location: request.service?.name!.match( - RegExp('(?[^/]+)') - )![0], + location: reqService.name!.match(RegExp('(?[^/]+)'))![0], }); } diff --git a/packages/google-cloud-run/test/gapic_revisions_v2.ts b/packages/google-cloud-run/test/gapic_revisions_v2.ts index fa93fe10664..22229547a7a 100644 --- a/packages/google-cloud-run/test/gapic_revisions_v2.ts +++ b/packages/google-cloud-run/test/gapic_revisions_v2.ts @@ -672,7 +672,6 @@ describe('v2.RevisionsClient', () => { const request = generateSampleMessage( new protos.google.cloud.run.v2.ListRevisionsRequest() ); - const expectedHeaderRequestParams = ''; const expectedResponse = [ generateSampleMessage(new protos.google.cloud.run.v2.Revision()), generateSampleMessage(new protos.google.cloud.run.v2.Revision()), @@ -711,7 +710,6 @@ describe('v2.RevisionsClient', () => { const request = generateSampleMessage( new protos.google.cloud.run.v2.ListRevisionsRequest() ); - const expectedHeaderRequestParams = ''; const expectedError = new Error('expected'); client.descriptors.page.listRevisions.createStream = stubPageStreamingCall(undefined, expectedError); @@ -745,7 +743,6 @@ describe('v2.RevisionsClient', () => { const request = generateSampleMessage( new protos.google.cloud.run.v2.ListRevisionsRequest() ); - const expectedHeaderRequestParams = ''; const expectedResponse = [ generateSampleMessage(new protos.google.cloud.run.v2.Revision()), generateSampleMessage(new protos.google.cloud.run.v2.Revision()), @@ -776,7 +773,6 @@ describe('v2.RevisionsClient', () => { const request = generateSampleMessage( new protos.google.cloud.run.v2.ListRevisionsRequest() ); - const expectedHeaderRequestParams = ''; const expectedError = new Error('expected'); client.descriptors.page.listRevisions.asyncIterate = stubAsyncIterationCall(undefined, expectedError); diff --git a/packages/google-cloud-run/test/gapic_services_v2.ts b/packages/google-cloud-run/test/gapic_services_v2.ts index ff0347dcc45..146a5e3bf47 100644 --- a/packages/google-cloud-run/test/gapic_services_v2.ts +++ b/packages/google-cloud-run/test/gapic_services_v2.ts @@ -1431,7 +1431,6 @@ describe('v2.ServicesClient', () => { const request = generateSampleMessage( new protos.google.cloud.run.v2.ListServicesRequest() ); - const expectedHeaderRequestParams = ''; const expectedResponse = [ generateSampleMessage(new protos.google.cloud.run.v2.Service()), generateSampleMessage(new protos.google.cloud.run.v2.Service()), @@ -1470,7 +1469,6 @@ describe('v2.ServicesClient', () => { const request = generateSampleMessage( new protos.google.cloud.run.v2.ListServicesRequest() ); - const expectedHeaderRequestParams = ''; const expectedError = new Error('expected'); client.descriptors.page.listServices.createStream = stubPageStreamingCall( undefined, @@ -1506,7 +1504,6 @@ describe('v2.ServicesClient', () => { const request = generateSampleMessage( new protos.google.cloud.run.v2.ListServicesRequest() ); - const expectedHeaderRequestParams = ''; const expectedResponse = [ generateSampleMessage(new protos.google.cloud.run.v2.Service()), generateSampleMessage(new protos.google.cloud.run.v2.Service()), @@ -1537,7 +1534,6 @@ describe('v2.ServicesClient', () => { const request = generateSampleMessage( new protos.google.cloud.run.v2.ListServicesRequest() ); - const expectedHeaderRequestParams = ''; const expectedError = new Error('expected'); client.descriptors.page.listServices.asyncIterate = stubAsyncIterationCall(undefined, expectedError);