Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete all sessions when dropping database #1244

Merged
merged 1 commit into from Aug 24, 2018
Merged

Delete all sessions when dropping database #1244

merged 1 commit into from Aug 24, 2018

Conversation

jdpedrie
Copy link
Contributor

Fixes #1215.

@jdpedrie jdpedrie added the api: spanner Issues related to the Spanner API. label Aug 24, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2018
@dwsupplee dwsupplee merged commit 93b3cf9 into googleapis:master Aug 24, 2018
@jdpedrie jdpedrie deleted the spanner-drop-database branch August 24, 2018 17:39
snehashah16
snehashah16 reviewed Aug 24, 2018
View reviewed changes
Copy link

@snehashah16 snehashah16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Spanner/src/Database.php
$this->sessionPool->clear();
}

if ($this->session) {

This comment was marked as spam.

Sign in to view

@jdpedrie jdpedrie mentioned this pull request Aug 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snehashah16 snehashah16 snehashah16 left review comments

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdpedrie @dwsupplee @snehashah16 @googlebot