New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure apis #943

Merged
merged 59 commits into from Mar 23, 2018

Conversation

Projects
None yet
4 participants
@dwsupplee
Member

dwsupplee commented Mar 23, 2018

#889 rebased and with a handful of updates to tooling.

michaelbausor and others added some commits Mar 2, 2018

Restructure testing (#929)
* Add system test credentials CLI

* Update Snippet testing for restructure

* Fix unit tests for restructure

* Fix system test runner

* Fix conformance bootstrap

* fix credentials CLIts

* Fix docs

* exclude dev folder from snippet parsing

* install latest composer

* Credentials CLI should not throw exception

* Test component integration

* Don't fail if extension is missing

* skip tests if debugger ext is missing

* Allow setting the search location paths for the SourceLocationResolver (#6)
@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Mar 23, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot commented Mar 23, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@dwsupplee dwsupplee merged commit 073358c into googleapis:master Mar 23, 2018

2 of 3 checks passed

cla/google CLAs are signed, but unable to verify author consent
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jdpedrie jdpedrie referenced this pull request Mar 27, 2018

Merged

Prepare v0.58.0 #960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment