Add api_core package #4210

theacodes · 2017-10-17T22:01:36Z

Note:

Added new module protobuf_helpers to break co-dependency on core. (This was going to be added anyway as I move helpers from gax)
This isn't in the docs yet but I'll do that a a separate PR.

dhermes

Cursory LGTM

.circleci/config.yml

+          command: |
+            if [[ -n $(grep api_core ~/target_packages) ]]; then
+              nox -f api_core/nox.py
+            fi


api_core/setup.py

@@ -0,0 +1,76 @@
+# Copyright 2016 Google Inc.


api_core/setup.py

+REQUIREMENTS = [
+    'googleapis-common-protos >= 1.5.3, < 2.0dev',
+    'protobuf >= 3.0.0',
+    'google-auth >= 0.4.0, < 2.0.0dev',


api_core/.coveragerc

+    def __repr__
+    # Ignore abstract methods
+    raise NotImplementedError
+    raise NotImplementedError()


lukesneeringer

Approved with a couple minor nits.

api_core/LICENSE

+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [yyyy] [name of copyright owner]


api_core/google/api_core/exceptions.py

+        return '{}, last exception: {}'.format(self.message, self.cause)
+
+
+class _GoogleAPICallErrorMeta(type):


api_core/google/api_core/gapic_v1/method.py

+        Sequence[Tuple(str, str)]: The gRPC-friendly metadata keys and values.
+    """
+    client_metadata = 'api-core/{} gl-python/{} grpc/{}'.format(
+        _API_CORE_VERSION, _PY_VERSION, _API_CORE_VERSION)


Add api_core package

2d60161

theacodes added the api: core label Oct 17, 2017

theacodes requested review from lukesneeringer and dhermes October 17, 2017 22:01

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2017

dhermes approved these changes Oct 17, 2017

View reviewed changes

lukesneeringer reviewed Oct 18, 2017

View reviewed changes

api_core/.coveragerc Outdated

def __repr__

# Ignore abstract methods

raise NotImplementedError

raise NotImplementedError()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

lukesneeringer approved these changes Oct 18, 2017

View reviewed changes

Address review comments

5f99bfd

theacodes merged commit b3197f0 into googleapis:master Oct 18, 2017

theacodes deleted the api-core-package-round-2 branch October 18, 2017 19:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add api_core package #4210

Add api_core package #4210

theacodes commented Oct 17, 2017

dhermes left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

lukesneeringer left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

		return '{}, last exception: {}'.format(self.message, self.cause)


		class _GoogleAPICallErrorMeta(type):

Add api_core package #4210

Add api_core package #4210

Conversation

theacodes commented Oct 17, 2017

dhermes left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

lukesneeringer left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.