From eb5644e91b48e656702e64e21512962d18a4621c Mon Sep 17 00:00:00 2001 From: Anthonios Partheniou Date: Fri, 26 Sep 2025 14:39:59 +0000 Subject: [PATCH 1/3] also create docs directory --- .generator/cli.py | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/.generator/cli.py b/.generator/cli.py index b09f5cb8f0cf..16032e899f80 100644 --- a/.generator/cli.py +++ b/.generator/cli.py @@ -330,6 +330,22 @@ def _copy_files_needed_for_post_processing(output: str, input: str, library_id: os.makedirs( f"{output}/{path_to_library}/scripts/client-post-processing", exist_ok=True ) + # This is needed to avoid the following error for proto-only libraries + # Traceback (most recent call last): + # File "/app/./cli.py", line 535, in handle_generate + # _run_post_processor(output, library_id) + # File "/app/./cli.py", line 300, in _run_post_processor + # python_mono_repo.owlbot_main(path_to_library) + # File "/usr/local/lib/python3.9/site-packages/synthtool/languages/python_mono_repo.py", line 310, in owlbot_main + # create_symlink_docs_readme(package_dir) + # File "/usr/local/lib/python3.9/site-packages/synthtool/languages/python_mono_repo.py", line 102, in create_symlink_docs_readme + # create_symlink_in_docs_dir(package_dir, "README.rst") + # File "/usr/local/lib/python3.9/site-packages/synthtool/languages/python_mono_repo.py", line 82, in create_symlink_in_docs_dir + # os.chdir(f"{package_dir}/docs") + # FileNotFoundError: [Errno 2] No such file or directory: 'packages/google-cloud-access-context-manager/docs' + os.makedirs( + f"{output}/{path_to_library}/docs", exist_ok=True + ) # TODO(https://github.com/googleapis/librarian/issues/2334): # if `.repo-metadata.json` for a library exists in # `.librarian/generator-input`, then we override the generated `.repo-metadata.json` From fe11829b590f6efb52d2d4a01ed684c017d06cd0 Mon Sep 17 00:00:00 2001 From: Anthonios Partheniou Date: Fri, 26 Sep 2025 15:29:40 +0000 Subject: [PATCH 2/3] additional fixes --- .generator/cli.py | 1 + 1 file changed, 1 insertion(+) diff --git a/.generator/cli.py b/.generator/cli.py index 16032e899f80..cbf07d9d79aa 100644 --- a/.generator/cli.py +++ b/.generator/cli.py @@ -330,6 +330,7 @@ def _copy_files_needed_for_post_processing(output: str, input: str, library_id: os.makedirs( f"{output}/{path_to_library}/scripts/client-post-processing", exist_ok=True ) + # TODO(https://github.com/googleapis/synthtool/pull/2126): Remove once this PR is merged # This is needed to avoid the following error for proto-only libraries # Traceback (most recent call last): # File "/app/./cli.py", line 535, in handle_generate From 07392a011ef5e58065251b6fff46bab74348b4c7 Mon Sep 17 00:00:00 2001 From: Anthonios Partheniou Date: Fri, 26 Sep 2025 15:35:05 +0000 Subject: [PATCH 3/3] chore(librarian): onboard google-cloud-access-context-manager --- .generator/cli.py | 17 ----------------- .librarian/state.yaml | 14 ++++++++++++++ .../packages_to_onboard.yaml | 1 + 3 files changed, 15 insertions(+), 17 deletions(-) diff --git a/.generator/cli.py b/.generator/cli.py index cbf07d9d79aa..b09f5cb8f0cf 100644 --- a/.generator/cli.py +++ b/.generator/cli.py @@ -330,23 +330,6 @@ def _copy_files_needed_for_post_processing(output: str, input: str, library_id: os.makedirs( f"{output}/{path_to_library}/scripts/client-post-processing", exist_ok=True ) - # TODO(https://github.com/googleapis/synthtool/pull/2126): Remove once this PR is merged - # This is needed to avoid the following error for proto-only libraries - # Traceback (most recent call last): - # File "/app/./cli.py", line 535, in handle_generate - # _run_post_processor(output, library_id) - # File "/app/./cli.py", line 300, in _run_post_processor - # python_mono_repo.owlbot_main(path_to_library) - # File "/usr/local/lib/python3.9/site-packages/synthtool/languages/python_mono_repo.py", line 310, in owlbot_main - # create_symlink_docs_readme(package_dir) - # File "/usr/local/lib/python3.9/site-packages/synthtool/languages/python_mono_repo.py", line 102, in create_symlink_docs_readme - # create_symlink_in_docs_dir(package_dir, "README.rst") - # File "/usr/local/lib/python3.9/site-packages/synthtool/languages/python_mono_repo.py", line 82, in create_symlink_in_docs_dir - # os.chdir(f"{package_dir}/docs") - # FileNotFoundError: [Errno 2] No such file or directory: 'packages/google-cloud-access-context-manager/docs' - os.makedirs( - f"{output}/{path_to_library}/docs", exist_ok=True - ) # TODO(https://github.com/googleapis/librarian/issues/2334): # if `.repo-metadata.json` for a library exists in # `.librarian/generator-input`, then we override the generated `.repo-metadata.json` diff --git a/.librarian/state.yaml b/.librarian/state.yaml index 1c3d2cc71f54..965821357fcf 100644 --- a/.librarian/state.yaml +++ b/.librarian/state.yaml @@ -1008,3 +1008,17 @@ libraries: remove_regex: - ^packages/googleapis-common-protos/google/(?:api|cloud|rpc|type)/.*/.*_pb2\.(?:py|pyi)$ tag_format: '{id}-v{version}' + - id: google-cloud-access-context-manager + version: 0.2.2 + last_generated_commit: 329ace5e3712a2e37d6159d4dcd998d8c73f261e + apis: + - path: google/identity/accesscontextmanager/v1 + service_config: accesscontextmanager_v1.yaml + - path: google/identity/accesscontextmanager/type + service_config: "" + source_roots: + - packages/google-cloud-access-context-manager + preserve_regex: [] + remove_regex: + - ^packages/google-cloud-access-context-manager/google/.*/.*_pb2\.(?:py|pyi)$ + tag_format: '{id}-v{version}' diff --git a/scripts/configure_state_yaml/packages_to_onboard.yaml b/scripts/configure_state_yaml/packages_to_onboard.yaml index 4081ebc335e3..030af6ecb783 100644 --- a/scripts/configure_state_yaml/packages_to_onboard.yaml +++ b/scripts/configure_state_yaml/packages_to_onboard.yaml @@ -26,6 +26,7 @@ packages_to_onboard: [ "google-apps-script-type", "google-area120-tables", "google-cloud-access-approval", + "google-cloud-access-context-manager", "google-cloud-advisorynotifications", "google-cloud-alloydb", "google-cloud-alloydb-connectors",