Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The offset param to the fetch method of a query did not work properly one there was a cursor #5503

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
4 participants
@mcdonc
Copy link
Contributor

commented Jun 15, 2018

This fixes the issue at #4675 where fetch executions that pass the offset parameter would return incorrect result values

Closes #4675.

@mcdonc mcdonc requested a review from theacodes as a code owner Jun 15, 2018

@googlebot

This comment has been minimized.

Copy link

commented Jun 15, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no label Jun 15, 2018

@mcdonc

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2018

@theacodes apologies, I did not have the email account I am using for Google communications associated with my GitHub account; I think that the Agendaless CLA has already been updated to include that account. I've now done that and to prevent future cla: no issues I've set user.email for my checkout of this repo to that email (chrismgoog@gmail.com). If I need to do anything else, please let know. Thanks!

@theacodes

This comment has been minimized.

Copy link
Member

commented Jun 15, 2018

@mcdonc no worries. Before I go and human-approve this, can you try re-writing your commits to update the author with the proper email? Should be able to do git commit --amend --update-author --no-edit and then git push -f.

@googlebot

This comment has been minimized.

Copy link

commented Jun 15, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jun 15, 2018

@mcdonc

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2018

@theacodes done and looks like googlebot cla-approved the result; thanks!

@theacodes

This comment has been minimized.

Copy link
Member

commented Jun 15, 2018

@tseaver tseaver merged commit fde9b59 into googleapis:master Jun 15, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed

enriquejosepadilla added a commit to enriquejosepadilla/google-cloud-python that referenced this pull request Jun 18, 2018

@theacodes theacodes referenced this pull request Jul 25, 2018

Merged

Release datastore 1.7.0 #5683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.