Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): add client_options to constructor #9151

Merged
merged 4 commits into from Oct 22, 2019
Merged

feat(spanner): add client_options to constructor #9151

merged 4 commits into from Oct 22, 2019

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 30, 2019 •
edited

Toward #8475

@busunkim96 busunkim96 added the api: spanner Issues related to the Spanner API. label Aug 30, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2019
@busunkim96 busunkim96 mentioned this pull request Aug 30, 2019
Closed
19 tasks
tseaver
tseaver approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @busunkim96 can you confirm that the api_endpoint will be the same betweeen the three clients?

@larkee
Copy link
Contributor

larkee commented Oct 18, 2019

LGTM. @busunkim96 can you confirm that the api_endpoint will be the same betweeen the three clients?

I can confirm that api_endpoint will be the same between the three clients. They all use the Client object's new _client_options attribute.

@busunkim96 busunkim96 changed the title Spanner: Add client_options to constructor. feat(spanner): add client_options to constructor Oct 19, 2019
@busunkim96 busunkim96 merged commit fbc10b8 into googleapis:master Oct 22, 2019
@busunkim96 busunkim96 deleted the spanner-client-options branch October 22, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@larkee larkee larkee approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@busunkim96 @larkee @tseaver @googlebot