Allow overriding bigquery table in acceptance tests #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Hi @blowmage @TheRoyalTnetennba , Please review the change and feel free to add anyone I missed. |
quartzmo
approved these changes
Dec 14, 2018
|
@yunpengw Are you testing |
|
@quartzmo Thanks for asking! I am testing master branch, so we don't need a release. |
blowmage
approved these changes
Dec 14, 2018
|
Great, I'll merge once Kokoro CI has passed. |
blowmage
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in bigquery_test would fail when tested in VPC environment.
Add the choice to override the bigquery table id with GCLOUD_TEST_SAMPLES_PUBLIC_TABLE, so we can let the test access sample tables within VPC