New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ruby 2.7 compatibility in Cloud::Config#mehtod_missing #4109
Fix Ruby 2.7 compatibility in Cloud::Config#mehtod_missing #4109
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
5ea9fcd
to
16bd37d
Compare
16bd37d
to
fd0763e
Compare
@blowmage I fixed both concerns. |
This PR should be rebased and rerun the build once #4116 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM.
@dazuma What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Recently an experimental feature has been merged in Ruby's master https://bugs.ruby-lang.org/issues/16150
In short
Symbol#to_s
will return a frozen string, whereas before it would always return a new mutable string.Because of this
Google::Cloud::Config#method_missing
breaks onruby-head
.The fix is quite straightforward, I simply reworked the code a little bit to avoid mutating the string.