Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New structure for jars in zip package #109

Closed
wonderfly opened this issue Jan 9, 2015 · 3 comments
Closed

New structure for jars in zip package #109

wonderfly opened this issue Jan 9, 2015 · 3 comments
Assignees

Comments

@wonderfly
Copy link
Contributor

@wonderfly wonderfly commented Jan 9, 2015

From yan...@google.com on May 09, 2012 11:01:25

External references, such as a standards document, or specification? http://google-http-java-client.googlecode.com/files/google-http-java-client-1.8.3-beta.zip https://code.google.com/p/google-http-java-client/source/browse/google-http-client-assembly/readme.html https://code.google.com/p/google-api-java-client/source/browse/tasks-android-sample/?repo=samples https://code.google.com/p/google-api-java-client/source/browse/tasks-android-sample/.classpath?repo=samples Java environments (e.g. Java 6, Android 2.3, App Engine, or All)? All Please describe the feature requested. Currently the google-http-client jars are at the root of the zip file, and the dependency jars are in the dependencies folder.

Instead, I propose a new structure which puts all of the binary jars in a "libs" folder and all of the source jars are in the "libs-sources" folder. No distinction between http base lib or the dependencies. This follows exactly the structure of the jars in tasks-android-sample.

One motivation is that for Android applications, the package manager requires the directory with all binary jars to be called "libs". Similarly, for HTTP servlets to jars must go in the war/WEB-INF/lib folder. Normally source jars aren't placed in this directory, so that's why I recommend also doing the same for libs-sources.

Additionally, we should provide the classpath entries to use for the .classpath file for Eclipse for the various platforms. It's just too much of a pain to craft them manually, and often people forget the sourcepath which makes it more difficult for debugging.

We should make the same changes in the projects that we own that depend on this project (api, oauth, etc).

Original issue: http://code.google.com/p/google-http-java-client/issues/detail?id=109

@wonderfly

This comment has been minimized.

Copy link
Contributor Author

@wonderfly wonderfly commented Jan 9, 2015

From rmis...@google.com on May 14, 2012 07:14:07

Labels: -Milestone-Version1.9.0 Milestone-Version1.10.0

@wonderfly

This comment has been minimized.

Copy link
Contributor Author

@wonderfly wonderfly commented Jan 9, 2015

From rmis...@google.com on May 14, 2012 07:14:53

Labels: -Milestone-Version1.10.0 Milestone-Version1.9.0

@wonderfly

This comment has been minimized.

Copy link
Contributor Author

@wonderfly wonderfly commented Jan 9, 2015

From rmis...@google.com on May 14, 2012 07:56:59

http://codereview.appspot.com/6203065/

Status: Fixed

@wonderfly wonderfly closed this Jan 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.