Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UrlEncodedContent class should use URI path encoding #1098

Closed
guillaumeblaquiere opened this issue Aug 28, 2020 · 0 comments · Fixed by #1100
Closed

UrlEncodedContent class should use URI path encoding #1098

guillaumeblaquiere opened this issue Aug 28, 2020 · 0 comments · Fixed by #1100
Assignees
Labels
priority: p2 type: bug

Comments

@guillaumeblaquiere
Copy link
Contributor

@guillaumeblaquiere guillaumeblaquiere commented Aug 28, 2020

UrlEncodedContent class use a deprecated URL encoder function. For another feature request in Google-auth-library-java (I will paste the link when the issue will be created), I need to use URI path encoding (especially for not encoding the + when I define a list of scopes in the auth library).

@yoshi-automation yoshi-automation added triage me 🚨 labels Aug 29, 2020
@chingor13 chingor13 added priority: p2 type: bug labels Sep 2, 2020
@yoshi-automation yoshi-automation removed triage me 🚨 labels Sep 2, 2020
@elharo elharo changed the title Improve UrlEncodedContent class to support URI path encoding UrlEncodedContent class should support URI path encoding Oct 7, 2020
@elharo elharo changed the title UrlEncodedContent class should support URI path encoding UrlEncodedContent class should use URI path encoding Oct 7, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 13, 2020
)

Fixes #1098 
The legacy behavior is kept. Test has been updated
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 type: bug
Projects
None yet
3 participants